Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make path_suffix_completions() work with multi segment path #428

Closed
Draggu opened this issue Mar 6, 2025 · 0 comments · Fixed by #501
Closed

Make path_suffix_completions() work with multi segment path #428

Draggu opened this issue Mar 6, 2025 · 0 comments · Fixed by #501
Assignees
@Draggu
Milestone
New completions

Comments

@Draggu
Copy link
Contributor

Draggu commented Mar 6, 2025

We should check not only last, but whole type path
@Draggu Draggu added this to the New completions milestone Mar 6, 2025
@Draggu Draggu self-assigned this Mar 6, 2025
@Draggu Draggu mentioned this issue Mar 6, 2025
Merged
@mkaput mkaput moved this from Triage to Todo in Cairo Language Services Mar 10, 2025
@Draggu Draggu moved this from Todo to In Progress in Cairo Language Services Mar 20, 2025
Draggu added a commit that referenced this issue Mar 21, 2025
@Draggu
Make path_suffix_completions() work with multi segment path
6684b25 
Close #428

Also restrict `path_prefix_completions()` to `Self` and paths in `use` statement as it makes no sense now to use this logic in other paths.

commit-id:eef9da6d
@Draggu Draggu mentioned this issue Mar 21, 2025
Merged
Draggu added a commit that referenced this issue Mar 26, 2025
@Draggu
Make path_suffix_completions() work with multi segment path
985e949 
Close #428

Also restrict `path_prefix_completions()` to `Self` and paths in `use` statement as it makes no sense now to use this logic in other paths.

commit-id:eef9da6d
Draggu added a commit that referenced this issue Mar 26, 2025
@Draggu
Make path_suffix_completions() work with multi segment path
c7fcfda 
Close #428

Also restrict `path_prefix_completions()` to `Self` and paths in `use` statement as it makes no sense now to use this logic in other paths.

commit-id:eef9da6d
Draggu added a commit that referenced this issue Mar 26, 2025
@Draggu
Make path_suffix_completions() work with multi segment path
0fc5006 
Close #428

Also restrict `path_prefix_completions()` to `Self` and paths in `use` statement as it makes no sense now to use this logic in other paths.

commit-id:eef9da6d
@github-project-automation github-project-automation bot moved this from In Progress to Done in Cairo Language Services Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Draggu Draggu

Labels
None yet
Projects
Cairo Language Services
Status: Done
Milestone
New completions
Development

Successfully merging a pull request may close this issue.

Make path_suffix_completions() work with multi segment path software-mansion/cairols
1 participant
@Draggu