Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to emphasize required filters hidden in GitBook collapsed field #466

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

priscaaeby
Copy link
Contributor

@priscaaeby priscaaeby commented Mar 14, 2025

Fix-it week https://snyksec.atlassian.net/browse/DP-3105
The required field is hidden when request body in GitBook is collapsed for V1 reporting API. I think we can't change that GitBook behaviour, but we can add a comment to emphasize there is a required field in the filters

@priscaaeby priscaaeby requested review from a team as code owners March 14, 2025 10:19
@mikeromard
Copy link
Collaborator

I've expanded everything on the reporting API reference page on the preview for this PR, and I don't see the new text in the output. That suggests to me that it needs to be added to a different spot in the spec, though I'm not sure where.

@priscaaeby where in the output do you want/expect this text to appear?

We'll need to change the text itself too, as we try to avoid using "please" in the docs.

@priscaaeby
Copy link
Contributor Author

I've expanded everything on the reporting API reference page on the preview for this PR, and I don't see the new text in the output. That suggests to me that it needs to be added to a different spot in the spec, though I'm not sure where.

@priscaaeby where in the output do you want/expect this text to appear?

We'll need to change the text itself too, as we try to avoid using "please" in the docs.

@mikeromard I updated the text of the description. I wonder if it was not working as I've inserted quotes, I fixed that. Can you please retry?

@mikeromard
Copy link
Collaborator

@mikeromard I updated the text of the description. I wonder if it was not working as I've inserted quotes, I fixed that. Can you please retry?

No luck. You can check the preview by clicking the GitBook - docs.snyk.io link in the checks section of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants