-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make setting of EventHub Partition Key configurable #148
Labels
Comments
colmsnowplow
added a commit
that referenced
this issue
Jul 4, 2022
colmsnowplow
added a commit
that referenced
this issue
Jul 7, 2022
colmsnowplow
added a commit
that referenced
this issue
Jul 8, 2022
colmsnowplow
added a commit
that referenced
this issue
Jul 8, 2022
colmsnowplow
added a commit
that referenced
this issue
Jul 21, 2022
colmsnowplow
added a commit
that referenced
this issue
Jul 21, 2022
colmsnowplow
added a commit
that referenced
this issue
Jul 21, 2022
colmsnowplow
added a commit
that referenced
this issue
Jul 22, 2022
colmsnowplow
added a commit
that referenced
this issue
Jul 22, 2022
colmsnowplow
added a commit
that referenced
this issue
Jul 22, 2022
colmsnowplow
added a commit
that referenced
this issue
Jul 22, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 12, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 12, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 12, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current behaviour of eventHub target is to set the Partition Key to whatever the message partition key is.
In instrumenting unit testing for this package, I discovered that this actually impedes the EventHub client's batching behaviour, which appears to be as follows:
So, our current instrumentation creates a scenario where default behaviour is that we only have single event batches - because we always explicitly set the partition key.
If the user is setting the partition key via transformation, we will batch appropriately.
I propose we introduce an option to not set the PK in the EH event.
That leaves the question of default behaviour. The options are:
Since option 1 keeps the nuance contained within the EventHubs target's configuration docs, I prefer that. Open to alternative viewpoints.
The text was updated successfully, but these errors were encountered: