Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail tests on NewConfig error #145

Closed
adatzer opened this issue Jun 20, 2022 · 0 comments
Closed

Fail tests on NewConfig error #145

adatzer opened this issue Jun 20, 2022 · 0 comments
Labels
cleanup Maintenance, cleaning up codebase or repo
Milestone
Release 1.0.0

Comments

@adatzer
Copy link
Contributor

adatzer commented Jun 20, 2022

In some tests we call NewConfig and then assert it is not nil. If there is an error, the assertion will fail, however the test will continue. At the same time, in that case the config will be nil, which then triggers a panic for following assertions on its fields. We could fail the test instead.
adatzer added a commit that referenced this issue Jun 21, 2022
@adatzer
Fail tests on NewConfig error (closes #145)
910929d
@colmsnowplow colmsnowplow added the cleanup Maintenance, cleaning up codebase or repo label Jun 24, 2022
colmsnowplow pushed a commit that referenced this issue Jul 1, 2022
@adatzer @colmsnowplow
Fail tests on NewConfig error (closes #145)
724b27d
colmsnowplow pushed a commit that referenced this issue Jul 1, 2022
@adatzer @colmsnowplow
Fail tests on NewConfig error (closes #145)
ef3cd6a
@colmsnowplow colmsnowplow added this to the Release 1.0.0 milestone Jul 4, 2022
colmsnowplow pushed a commit that referenced this issue Jul 22, 2022
@adatzer @colmsnowplow
Fail tests on NewConfig error (closes #145)
e2669a5
colmsnowplow pushed a commit that referenced this issue Jul 22, 2022
@adatzer @colmsnowplow
Fail tests on NewConfig error (closes #145)
3d0f616
colmsnowplow pushed a commit that referenced this issue Jul 22, 2022
@adatzer @colmsnowplow
Fail tests on NewConfig error (closes #145)
39cbfe4
colmsnowplow pushed a commit that referenced this issue Jul 22, 2022
@adatzer @colmsnowplow
Fail tests on NewConfig error (closes #145)
3d8e979
colmsnowplow pushed a commit that referenced this issue Aug 12, 2022
@adatzer @colmsnowplow
Fail tests on NewConfig error (closes #145)
77e9eda
colmsnowplow pushed a commit that referenced this issue Aug 12, 2022
@adatzer @colmsnowplow
Fail tests on NewConfig error (closes #145)
9decdc7
colmsnowplow pushed a commit that referenced this issue Aug 12, 2022
@adatzer @colmsnowplow
Fail tests on NewConfig error (closes #145)
4569d1b
colmsnowplow pushed a commit that referenced this issue Aug 12, 2022
@adatzer @colmsnowplow
Fail tests on NewConfig error (closes #145)
9938cc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Maintenance, cleaning up codebase or repo
Projects
None yet
Milestone
Release 1.0.0
Development

No branches or pull requests
2 participants
@colmsnowplow @adatzer