Fix possible override of entity values when generating variations #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
addresses #807 |
Codecov Report
@@ Coverage Diff @@
## develop #808 +/- ##
===========================================
+ Coverage 88.38% 88.42% +0.03%
===========================================
Files 76 76
Lines 4590 4588 -2
Branches 890 889 -1
===========================================
Hits 4057 4057
+ Misses 396 395 -1
+ Partials 137 136 -1 |
ClemDoum
approved these changes
Jun 11, 2019
|
I'm having some issues where slots are sometimes filled with the word that has the case changed, ie. password is changed to Password. We are working around the issue by referencing the rawvalue for the slot. I''m wondering if this is a result of the same issue. |
|
@Shotgun167 This is indeed very likely to be caused by this issue. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When augmenting the dataset, variations of utterance entity values were added without checking possible collisions with other utterance entity values.
Checklist: