Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/2: check window sizes, implement streaming #158

Merged
merged 8 commits into from
Dec 12, 2021
+328 −53
Merged

HTTP/2: check window sizes, implement streaming #158

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
016d7ea
HTTP/2: check window sizes
the-mikedavis Oct 29, 2021
3b11fcf
document passing a stream body for HTTP/2
the-mikedavis Oct 29, 2021
2eae2ec
use macro-form put_in/2 consistently
the-mikedavis Nov 30, 2021
336e638
only continue streaming when the connection is open for writing
the-mikedavis Nov 30, 2021
c49ea5d
discard streaming requests when closed for writing
the-mikedavis Nov 30, 2021
21d53d4
fix off-by-one error in byte-fitting formula
the-mikedavis Dec 5, 2021
11dd75e
combine Enum.filter/2 and Enum.reduce/3 calls
the-mikedavis Dec 6, 2021
466bf4b
don't call IO.iodata_to_binary/1 on binary input
the-mikedavis Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
don't call IO.iodata_to_binary/1 on binary input
@the-mikedavis
the-mikedavis committed Dec 6, 2021
commit 466bf4bd6ca1d2b3ad473be3023a7fd28d682cc2
10 changes: 7 additions & 3 deletions lib/finch/http2/request_stream.ex
View file
Original file line number Diff line number Diff line change
@@ -11,9 +11,13 @@ defmodule Finch.HTTP2.RequestStream do
end

enumerable =
Stream.map(enumerable, fn data ->
binary_data = IO.iodata_to_binary(data)
{binary_data, byte_size(binary_data)}
Stream.map(enumerable, fn
binary when is_binary(binary) ->
{binary, byte_size(binary)}

io_data ->
binary = IO.iodata_to_binary(io_data)
{binary, byte_size(binary)}
end)

reducer = &reduce_with_suspend/2