Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Optimism L1 Oracle to support Mantle #14160

Merged
merged 25 commits into from
Aug 22, 2024
Merged

Changed Optimism L1 Oracle to support Mantle #14160

merged 25 commits into from
Aug 22, 2024
+188 −7

Conversation

ma33r
Copy link
Contributor

@ma33r ma33r commented Aug 20, 2024 •
edited
Loading

What

  • Changes our existing op_l1_oracle to support the Mantle Network. Specifically, for Mantle, the tokenRatio parameter is retrieved and used to calculate a gas price
  • Closes BCI-3964

Why

  • Mantle's gas price formula is similar to that of Optimism Bedrock, but it also includes a parameter called tokenRatio. The docs detailing this can be found here

ma33r added 3 commits August 20, 2024 08:27
@ma33r
edited op stack oracle to include tokenRatio for Mantle

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
6b0b72b
@ma33r
typo fix

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
cde83ea
@ma33r
Merge branch 'develop' into bci-3964-mantle-gas-oracle

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
eff9ea7
@ma33r ma33r changed the title edited op stack oracle to include tokenRatio for Mantle Changed Optimism L1 Oracle to support Mantle Aug 20, 2024
ma33r and others added 12 commits August 20, 2024 09:51
@ma33r
fixed syntax errors

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
ef3f4c5
@ma33r
fixed compilation errors in test

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
e520d2c
@ma33r
added unit tests for Mantle oracle changes

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
5676e39
@ma33r
typo fix

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
88ea6c3
@ma33r
Merge branch 'develop' into bci-3964-mantle-gas-oracle

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
b607511
@ma33r
added changeset file

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
3076e6a
@ma33r
added hashtag to changeset

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
ccfbaf4
@ma33r
changed unit test to include new chaintype

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
6d6f8fe
@ma33r
changed test to include new chaintype

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
b4cbe2e
@ma33r
typo fix

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
7e80412
@ma33r
Merge branch 'develop' into bci-3964-mantle-gas-oracle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
3ddcec7
@ma33r
Merge branch 'develop' into bci-3964-mantle-gas-oracle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
044c87d
@ma33r ma33r marked this pull request as ready for review August 21, 2024 13:07
@ma33r ma33r requested review from a team as code owners August 21, 2024 13:07
@ma33r
Merge branch 'develop' into bci-3964-mantle-gas-oracle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
6a83c3a
@ma33r
addressed alphabetical order and error issues

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
d9185cc
ma33r and others added 2 commits August 21, 2024 13:17
@ma33r
used batch call instead of separate calls for L1 Base Fee

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
7cf35b2
@ma33r
Merge branch 'develop' into bci-3964-mantle-gas-oracle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
10415c7
ma33r and others added 2 commits August 21, 2024 14:41
@ma33r
added test cases for RPC errors to Mantle

Verified

This commit was signed with the committer’s verified signature.
ma33r Matthew Romage
SSH Key Fingerprint: YA8CS6CFoAymsTpYpTHdrjnsWRHvNqaP1y3H6HzwZ0U
Verified
Learn about vigilant mode
Loading
Loading status checks…
ed8db2f
@ma33r
Merge branch 'develop' into bci-3964-mantle-gas-oracle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
cd051f4
amit-momin
amit-momin approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@amit-momin amit-momin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaszcl
Copy link
Collaborator

lukaszcl commented Aug 21, 2024 •
edited
Loading

@ma33r please merge develop to this branch (click "Update branch"). Otherwise the PR may be stuck in merge queue. This is due to recent CI changes made on develop.

ma33r added 4 commits August 22, 2024 09:22
@ma33r
Merge branch 'develop' into bci-3964-mantle-gas-oracle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
74c62bc
@ma33r
Merge branch 'develop' into bci-3964-mantle-gas-oracle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
b158efb
@ma33r
Merge branch 'develop' into bci-3964-mantle-gas-oracle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
1e34607
@ma33r
Merge branch 'develop' into bci-3964-mantle-gas-oracle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
5692a55
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
10.4% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

huangzhen1997
huangzhen1997 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@huangzhen1997 huangzhen1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Aug 22, 2024
Merged via the queue into develop with commit c98feb2 Aug 22, 2024
133 of 135 checks passed
@prashantkumar1982 prashantkumar1982 deleted the bci-3964-mantle-gas-oracle branch August 22, 2024 19:50
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Draft
mateusz-sekara pushed a commit that referenced this pull request Jan 10, 2025
@ma33r @matYang
Changed Optimism L1 Oracle to support Mantle (#14160)

Partially verified

This commit is signed with the committer’s verified signature.
matYang’s contribution has been verified via SSH key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
f40af80 
* edited op stack oracle to include tokenRatio for Mantle

* typo fix

* fixed syntax errors

* fixed compilation errors in test

* added unit tests for Mantle oracle changes

* typo fix

* added changeset file

* added hashtag to changeset

* changed unit test to include new chaintype

* changed test to include new chaintype

* typo fix

* addressed alphabetical order and error issues

* used batch call instead of separate calls for L1 Base Fee

* added test cases for RPC errors to Mantle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangzhen1997 huangzhen1997

@prashantkumar1982 prashantkumar1982

@amit-momin amit-momin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ma33r @lukaszcl @huangzhen1997 @prashantkumar1982 @amit-momin