Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide the nested context API #404

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Provide the nested context API #404

merged 1 commit into from
Mar 27, 2025
+428 −3

Conversation

cescoffier
Copy link
Contributor

Initial implementation of #402.

@cescoffier cescoffier force-pushed the nested-context branch 2 times, most recently from 7a787bf to 04cce77 Compare March 24, 2025 18:55
@cescoffier cescoffier mentioned this pull request Mar 24, 2025
Closed
@cescoffier cescoffier marked this pull request as ready for review March 25, 2025 06:46
@cescoffier cescoffier force-pushed the nested-context branch 2 times, most recently from 096e877 to bc3668e Compare March 25, 2025 07:09
@cescoffier
Copy link
Contributor Author

Fighting against stupid javadoc rules...

dmlloyd
dmlloyd previously approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good to me. I can only assume that the semantics are correct. :-)

brunobat
brunobat approved these changes Mar 25, 2025
View reviewed changes
Copy link

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cescoffier
Copy link
Contributor Author

@jponge can you have a look?

jponge
jponge approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@jponge jponge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good to me!

radcortez
radcortez previously approved these changes Mar 27, 2025
View reviewed changes
@cescoffier
Provide the nested context API

Verified

This commit was signed with the committer’s verified signature.
cescoffier Clement Escoffier
SSH Key Fingerprint: 3vCqKUiqJ8b2H10kz/LcKm2CWJVE62iue63raeybAmg
Verified
Learn about vigilant mode
Loading
Loading status checks…
dc0cade
@cescoffier cescoffier dismissed stale reviews from radcortez and dmlloyd via dc0cade March 27, 2025 13:06
@cescoffier cescoffier merged commit 9d159f8 into main Mar 27, 2025
4 checks passed
@cescoffier cescoffier deleted the nested-context branch March 27, 2025 13:52
@github-actions github-actions bot added this to the 3.0.0 milestone Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jponge jponge

@brunobat brunobat

@geoand geoand

@dmlloyd dmlloyd

@radcortez radcortez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cescoffier @jponge @dmlloyd @brunobat @geoand @radcortez