Fix input encoding, removing the need for Cleaner class #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garak
reviewed
May 28, 2018
src/Converter.php
Outdated
| @@ -41,14 +41,15 @@ public function getAsHtml(): string | |||
|
|
|||
| private function convert(string $data, int $startPage, int $numOfPages): void | |||
| { | |||
| $crawler = new Crawler($data); | |||
| $crawler = new Crawler(); | |||
|
Can we add a test to ensure that a text with "strange" character is converted, as we expect? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dom Crawler Component of Symfony has a strange behaviour: if you load html string in the constructor, it cannot handle the utf-8 encoding.
Quick fix: using an empty constructor then passing the html string to the
addHtmlContentmethod, this way the encoding is handled correctly thus making the Cleaner class not needed anymore.See: https://www.hieule.info/programming/symfony-dom-crawler-component-utf-8-html