Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI and add tests for latest ruby/rspec #111

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Drowze
Copy link

@Drowze Drowze commented Feb 17, 2025

  • CI: Fix usage of deprecated actions:
  • Add tests for latest ruby/rspec
    • Added tests for ruby 3.2, 3.3 and 3.4
    • Added tests for RSpec 3.11, 3.12, 3.13

Notes:

  • Ruby 3.2+ is not compatible with RSpec <= 3.3, so the CI workflow was updated accordingly
  • I was getting too many dependency errors trying to use the same Gemfile.lock file on all ruby versions, so following Apprails's recommendation, I added gemfiles/*.lock to .gitignore.

Successful CI run:
https://github.com/Drowze/rspec_junit_formatter/actions/runs/13376950471
Screenshot 2025-02-17 at 16 12 32

NOTE: added all `gemfiles/*.lock` files to gitignore to avoid issues
trying to resolve versions in CI. It's also recomended by Appraisal gem
itself:

> When using Appraisal, we recommend you check in the Gemfiles that
> Appraisal generates within the gemfiles directory, but exclude the
> lockfiles there (*.gemfile.lock.)

Source:
https://github.com/thoughtbot/appraisal?tab=readme-ov-file#version-control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant