Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: QuillEditor doesn't respect the system keyboard brightness by default on iOS #2522

Merged
merged 3 commits into from
Mar 23, 2025
Merged

fix: QuillEditor doesn't respect the system keyboard brightness by default on iOS #2522

merged 3 commits into from
Mar 23, 2025

Conversation

EchoEllet
Copy link
Collaborator

@EchoEllet EchoEllet commented Mar 23, 2025 •
edited
Loading

Description

Fix iOS not defaulting the system keyboard brightness to the system and is hardcoded to light.

Related Issues

Screenshots

Before the fix

Before the fix

After the fix

After the fix

Type of Change

  • ✨ Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • ❌ Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • ✅ Build configuration change: Build/configuration changes.

@EchoEllet EchoEllet marked this pull request as draft March 23, 2025 17:32
CatHood0

This comment was marked as outdated.

Sign in to view

@EchoEllet
test: add tests for keyboardAppearance, characterShortcutEvents and s…
6ca4d03 
…paceShortcutEvents are no longer required, Deprecate in favor of
@EchoEllet EchoEllet marked this pull request as ready for review March 23, 2025 18:05
@EchoEllet EchoEllet requested a review from CatHood0 March 23, 2025 18:05
@EchoEllet EchoEllet mentioned this pull request Mar 23, 2025
Merged
8 tasks
@EchoEllet EchoEllet requested a review from singerdmx March 23, 2025 18:08
CatHood0
CatHood0 approved these changes Mar 23, 2025
View reviewed changes
Copy link
Collaborator

@CatHood0 CatHood0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for add test to this change.

@EchoEllet EchoEllet merged commit 4188c34 into master Mar 23, 2025
7 checks passed
@EchoEllet EchoEllet deleted the fix/2521 branch March 23, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatHood0 CatHood0 CatHood0 approved these changes

@singerdmx singerdmx Awaiting requested review from singerdmx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QuillEditor doesn't respect the system keyboard brightness by default on iOS
2 participants
@EchoEllet @CatHood0