OmitDeep
: Fix removal of multiple paths within arrays
#1049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #959 (comment)
Just enabling
recurseIntoArrays
forSharedUnionDeep
withinOmitDeep
fixes the above issue, however, it causes some existing test cases to fail, asSharedUnionDeep
currently fails when instantiated with arrays where the non-fixed part precedes the fixed part (will open an issue for this).So, this PR removes usage of
SharedUnionDeep
fromOmitDeep
and replaces it with logic similar to what is used inSetRequiredDeep
.type-fest/source/set-required-deep.d.ts
Lines 47 to 55 in 81a0540