Poll consumer #79
Open
Poll consumer #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I didn't reviewed yet but I see travis builds are broken: https://app.travis-ci.com/github/silviucpp/erlkaf/jobs/631024352 |
macasado86
force-pushed
the
poll-consumer
branch
from
e98c3e3 to
2bac9e5
Compare
|
Hi, I have changed the second commit and now travis builds pass correctly. Thanks |
|
Also documentation need to be updated https://github.com/silviucpp/erlkaf/blob/master/README.MD#consumer-api to include the second polling mechanism. |
macasado86
force-pushed
the
poll-consumer
branch
from
2bac9e5 to
e20a3e4
Compare
|
Sorry, I forgot it. Now you have it. |
macasado86
force-pushed
the
poll-consumer
branch
from
e20a3e4 to
e5569ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Silviu,
This is the PR according to the issue I opened about the explicit poll consumer.
Instead of creating a
consumer_behaviourto implement by anyone who wants to implement their own consumer, I have created aconsumer_group_behaviourmodule to do that at consumer group level. The main reason is that I needed to create apollfunction inside the consumer_group module and perhaps it is preferable to keep it separated from the current functionality. Anyway, I can change it if necessary