Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Otel] Remove debugging; Use different header #3538

Merged
merged 2 commits into from
Jan 24, 2025
Merged

[Otel] Remove debugging; Use different header #3538

merged 2 commits into from
Jan 24, 2025

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 24, 2025

Reverts/revises parts of #3533, #3537

Resolves #3534 (hopefully)


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working backend labels Jan 24, 2025
@imnasnainaec imnasnainaec self-assigned this Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.61%. Comparing base (7fc04b1) to head (13147e1).
Report is 53 commits behind head on master.

Files with missing lines Patch % Lines
Backend/Otel/LocationProvider.cs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3538      +/-   ##
==========================================
+ Coverage   66.34%   74.61%   +8.26%     
==========================================
  Files         234      285      +51     
  Lines        5847    11032    +5185     
  Branches      713     1341     +628     
==========================================
+ Hits         3879     8231    +4352     
- Misses       1740     2419     +679     
- Partials      228      382     +154     
Flag Coverage Δ
backend 83.93% <75.00%> (?)
frontend 66.34% <ø> (+0.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec changed the title [DEBUG] Remove debugging; Restore IP machinery we might need [Otel] Remove debugging; Use different header Jan 24, 2025
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit b1db050 into master Jan 24, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the rebug-qa branch January 24, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[analytics] Location analytics from QA always show Dallas
2 participants