Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @mui/x-date-pickers and Project Schedule settings #2876

Merged
merged 8 commits into from
Jan 16, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 10, 2024

This is prerequisite for installing material-react-table for #2875

Changes:

  • install @mui/x-date-pickers (v6)
    • update frontend license report
  • replace English-stuck component-specific LocalizationProvider wrappers with one DatePickersLocalizationProvider in AppLoggedIn
    • use current i18next language in DatePickersLocalizationProvider
    • add LocalizationProvider to the ProjectSettings tests (now necessary for the schedule settings with mui/x-date-pickers components without their own providers)
  • replace deprecated CalendarPicker with DateCalendar
    • remove unnecessary date and onChange props
    • update prop defaultCalendarMonth to referenceDate
    • replace deprecated renderDay with corresponding usage of slots and slotProps
    • extract two instances of customDayRenderer for a common ProjectPickersDay component
  • remove style={{ width: 100 }} from button-holding Grids (sizing that assumed English ui)
  • add useEffect with Modal.setAppElement("body"); to prevent a console error

This change is Reviewable

@imnasnainaec imnasnainaec added frontend project dependencies Pull requests that update a dependency file labels Jan 10, 2024
@imnasnainaec imnasnainaec self-assigned this Jan 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (11523e3) 72.56% compared to head (911805f) 72.61%.

Files Patch % Lines
...components/App/DatePickersLocalizationProvider.tsx 0.00% 2 Missing ⚠️
...jectSettings/ProjectSchedule/ProjectPickersDay.tsx 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2876      +/-   ##
==========================================
+ Coverage   72.56%   72.61%   +0.04%     
==========================================
  Files         262      264       +2     
  Lines        9976     9972       -4     
  Branches     1163     1162       -1     
==========================================
+ Hits         7239     7241       +2     
+ Misses       2398     2391       -7     
- Partials      339      340       +1     
Flag Coverage Δ
backend 83.36% <ø> (ø)
frontend 62.60% <76.92%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review January 11, 2024 15:33
@imnasnainaec imnasnainaec added bug Something isn't working font/language labels Jan 11, 2024
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After class comment on ProjectPickersDayf :LGTM:

Reviewed 1 of 7 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: 9 of 11 files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Reviewable status: 8 of 11 files reviewed, all discussions resolved (waiting on @imnasnainaec and @jasonleenaylor)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 7 files at r1, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 761f557 into master Jan 16, 2024
@imnasnainaec imnasnainaec deleted the mui-x-date-pickers branch January 16, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file font/language frontend project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants