[TreeView] Show only current tile on sm screens; Fix minor layout issues #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2837 +/- ##
=======================================
Coverage 72.33% 72.33%
=======================================
Files 257 255 -2
Lines 9524 9519 -5
Branches 1096 1096
=======================================
- Hits 6889 6886 -3
+ Misses 2308 2306 -2
Partials 327 327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jasonleenaylor
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Reviewed 5 of 8 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
|
I reviewed the Codecov details and didn't see how the uncovered click was covered before. I don't believe that we actually lost any real covereage. |
jmgrady
pushed a commit
that referenced
this pull request
Mar 6, 2024
…ues (#2837) * Hide all but the current domain tile for xs and sm width windows: resolves #2682, though for domains with lots of subdomains, a small amount of horizontal scrolling required with md width (600-850 px) * Prevent large semantic domain names from distorting the tree when viewing their children: fixes #2836 * Prevent a scrollbar from showing up in the middle of the page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<ImageList>from the parent row: fixes Large semantic domain names distort the tree when viewing their children #2836xsandsmwidth windows: resolves Domain tree doesn't fit horizontally in small-width windows #2682overflow: "visible"to the children row to prevent a scrollbar from showing up in the middle of the pageThis change is