Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JSON along with comments and error handling #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mishra-aayush
Copy link

No description provided.

@shivam212
Copy link
Owner

I don't think this is what we want. What we want is

  • A JSON file that works the same as the txt file, i.e stores the names of the channel.
  • A helper function that writes the usernames of the channels the user would want to download the videos from.
  • Another helper function that reads the usernames from the json file and sends it to the downloader function.

What you have you done is -

  • A helper function which does both read/write together.
  • Your invocation will each time run the user_input function and prompt the user. What we want is the user to have a seperate function to add usernames.
  • The downloader function be invoked after reading all the channels off the json file, like we did with the txt previously.
    A simple menu when the program is run which asks the user to select from 1) add channel, 2) remove channel, 3) download videos would be great.(We can turn this menu to a CLI based menu with click in the future)
    Also don't use global anywhere, will hinder us in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants