Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizes metric ammo names #4455

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Apogee-dev
Copy link
Contributor

@Apogee-dev Apogee-dev commented Mar 22, 2025

About The Pull Request

Changes nearly all player-facing instances of 10mm, 9mm, and 6.5mm to use the expanded format used for other metric cartridges; 10x22mm, 9x18mm, and 7.5x64mm respectively (6.5 was renamed because its stats imply a much larger cartridge; something ever so slightly faster than .30-06 makes sense, if it's supposed to be comparable to .300)

Why It's Good For The Game

If I have to hear one more player gripe about 10mm in-game being the same as .45 despite 10mm Auto being a much more powerful cartridge irl i'm probably gonna put a hole in the drywall

Changelog

🆑
fix: 10mm and 9mm cartridges now use the proper metric name format
fix: 6.5mm CLIP renamed to 7.5x64mm CLIP
/:cl:

@Apogee-dev Apogee-dev requested review from FalloutFalcon and a team as code owners March 22, 2025 20:53
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested. Code change Watch something violently break. labels Mar 22, 2025
@github-actions github-actions bot added Ruin Ruin successfully tested. Merge Conflict Use Git Hooks, you're welcome. labels Mar 25, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested. Ship Ship successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant