Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v4 components): use radix-ui mono package #6868

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CHC383
Copy link

@CHC383 CHC383 commented Mar 5, 2025

Close #6428

This PR updates all the @radix-ui/* imports in v4 to use the new radix-ui package.

@shadcn I didn't touch the old Tailwind v3 based components as I am not sure if you want to bring these updates there, but I am open to contribute if you want.

Copy link

vercel bot commented Mar 5, 2025

@CHC383 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@CHC383 CHC383 changed the title refactor(components): use radix-ui mono package refactor(v4 components): use radix-ui mono package Mar 5, 2025
@shadcn
Copy link
Collaborator

shadcn commented Mar 6, 2025

Let's test.

Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Mar 10, 2025 10:09am
v4 ✅ Ready (Inspect) Visit Preview Mar 10, 2025 10:09am

@shadcn shadcn added this to the v4 milestone Mar 6, 2025
@shadcn shadcn added the area: roadmap This looks great. We'll add it to the roadmap, review and merge. label Mar 6, 2025
@shadcn
Copy link
Collaborator

shadcn commented Mar 6, 2025

Looks good. I'll keep testing and merge.

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CHC383 Looks good. I left two minor comments.

@shadcn
Copy link
Collaborator

shadcn commented Mar 12, 2025

@CHC383 I think I'm going to move this one to the next milestone. I definitely want to do it but some v4 projects have already shipped with the @radix-ui/* deps and I'd like to offer a codemod to switch to the single package. Let me know what you think.

@shadcn shadcn modified the milestones: v4, next Mar 12, 2025
@CHC383
Copy link
Author

CHC383 commented Mar 12, 2025

@shadcn That sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: roadmap This looks great. We'll add it to the roadmap, review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat]: Switch to radix-ui mono package
3 participants