-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(v4 components): use radix-ui mono package #6868
base: main
Are you sure you want to change the base?
Conversation
@CHC383 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Let's test. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looks good. I'll keep testing and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CHC383 Looks good. I left two minor comments.
@CHC383 I think I'm going to move this one to the next milestone. I definitely want to do it but some v4 projects have already shipped with the |
@shadcn That sounds good to me |
Close #6428
This PR updates all the
@radix-ui/*
imports in v4 to use the newradix-ui
package.@shadcn I didn't touch the old Tailwind v3 based components as I am not sure if you want to bring these updates there, but I am open to contribute if you want.