sns-testing subcommands #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvem
commented
Mar 19, 2025
| } | ||
|
|
||
| #[derive(Debug, Parser)] | ||
| pub enum SnsTestingSubCommand { |
There was a problem hiding this comment.
Perhaps, it's worth splitting the sns-testing into two binaries: one to do the init part, and the other to run "scenarios"
rvem
force-pushed
the
rvem/sns-testing-subcommands
branch
from
b2a8929 to
3ae1280
Compare
rvem
force-pushed
the
serokell/sns-testing
branch
from
3c8c66a to
ee3a1fd
Compare
rvem
force-pushed
the
rvem/sns-testing-subcommands
branch
from
c8e88ad to
5023804
Compare
Currently, 'sns-testing' is only capable of deploying hardcoded SNS with the provided SNS-controlled canister. This makes it impossible to tweak SNS settings without recompiling 'sns-testing'. The suggested way to create SNSes is to use 'dfx sns propose' command. To support the workflow to deploy SNSes using this command, 'sns-testing' CLI was extended with the subcommand to complete the swap for the created SNS. 'sns-testing run swap-complete' will wait for swap to be open, generate required number of participation with sufficient amount of tokens to complete the swap, and wait for swap to be completed.
rvem
force-pushed
the
rvem/sns-testing-subcommands
branch
from
5023804 to
0d1a794
Compare
Extract NNS init part into a dedicated binary to simplify the interface.
rvem
force-pushed
the
rvem/sns-testing-subcommands
branch
from
0d1a794 to
96af6f0
Compare
sras
reviewed
Mar 20, 2025
rs/sns/testing/README.md
Outdated
|
|
||
| The suggested way to do this is to use `dfx sns propose` command. For more information please refer to the [documentation](https://internetcomputer.org/docs/building-apps/governing-apps/launching/launch-steps-1proposal#3-submit-nns-proposal-to-create-sns). | ||
|
|
||
| Make use to use `sns-testing` identity when creating the proposal. |
There was a problem hiding this comment.
Something seems off with this sentence.
sras
reviewed
Mar 20, 2025
rs/sns/testing/README.md
Outdated
| bazel run //rs/sns/testing:sns-testing -- --network http://127.0.0.1:8080 swap-complete --sns-name "<SNS name>" --follow-principal-neurons "$(dfx identity get-principal --identity sns-testing)" | ||
| ``` | ||
|
|
||
| This command will generate required number of participations with the sufficient amount of direct participations to complete the swap. |
There was a problem hiding this comment.
required number of participations
Not sure if you meant "participants" here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two subcommands to the
sns-testingbinary:sns-testing-related scenarios.