Fix breaking change from removing ShardRunnerMessage::Message #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GnomedDev
approved these changes
Mar 21, 2025
|
Cool, I'll let you handle the CI doc stuff when you get the chance |
mkrasnitski
reviewed
Mar 22, 2025
Comment on lines
+178
to
+180
| channel_id: channel_id | ||
| .map(ChannelId::get) | ||
| .map(serenity::all::ChannelId::from), |
There was a problem hiding this comment.
Why the roundtrip from ChannelId to u64 and back again?
There was a problem hiding this comment.
Songbird defines its own ID newtypes to be independent of whichever gateway a user wants, and the input is in our ID format. We have a From impl from serenity and twilight types to ours, but not apparently the opposite direction (hence the transformation here, I guess).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the compiler issue introduced in the "next" branch of serenity with the removal of the Message variant of ShardRunnerMessage enum in e552918.