Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move decode config into DecodeMode::Decode #272

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Move decode config into DecodeMode::Decode #272

merged 1 commit into from
Feb 23, 2025

Conversation

GnomedDev
Copy link
Member

This better models the configuration and shrinks UdpRxMessage significantly.

FelixMcFelix
FelixMcFelix approved these changes Feb 23, 2025
View reviewed changes
Copy link
Member

@FelixMcFelix FelixMcFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for reorganising there. Glad to cut down the message size there.

@GnomedDev GnomedDev merged commit 60bc222 into serenity-rs:next Feb 23, 2025
10 checks passed
@GnomedDev GnomedDev deleted the decode-config branch February 23, 2025 13:02
GnomedDev added a commit to GnomedDev/songbird that referenced this pull request Mar 27, 2025
@GnomedDev
Move decode config into DecodeMode::Decode (serenity-rs#272)
6ced46b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixMcFelix FelixMcFelix FelixMcFelix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @FelixMcFelix