Snowflake does not explicitly support collation in the same way as some other databases

[lbazetto]

Snowflake does not explicitly support collation in the same way as some other databases.

Like it shows in create table syntax
And in collation specification

So this fix removes Snowflake from DIALECTS_WITH_CHARSET_AND_COLLATE

[WikiRik]

In sequelize itself there is support for charset and collation when creating a database and table. Is that also incorrect? If so; could you make a corresponding PR for that?
https://github.com/sequelize/sequelize/blob/962e5c05c0ac92c7e6b5140ae56a3e12ba8165e7/packages/core/src/dialects/snowflake/query-generator-typescript.ts#L19
https://github.com/sequelize/sequelize/blob/962e5c05c0ac92c7e6b5140ae56a3e12ba8165e7/packages/core/src/dialects/snowflake/query-generator.js#L32

[lbazetto]

In sequelize itself there is support for charset and collation when creating a database and table. Is that also incorrect? If so; could you make a corresponding PR for that?
https://github.com/sequelize/sequelize/blob/962e5c05c0ac92c7e6b5140ae56a3e12ba8165e7/packages/core/src/dialects/snowflake/query-generator-typescript.ts#L19
https://github.com/sequelize/sequelize/blob/962e5c05c0ac92c7e6b5140ae56a3e12ba8165e7/packages/core/src/dialects/snowflake/query-generator.js#L32

Sure, PR has been created:
sequelize/sequelize#16962

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bfd7d5) 99.43% compared to head (548e48f) 99.43%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #641   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          12       12           
  Lines        1422     1422           
  Branches      257      257           
=======================================
  Hits         1414     1414           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mmkal]

@QuentinFarizon since you added this list, does this look ok to you?

[WikiRik]

Support for charset and collate was indeed incorrectly added for snowflake in sequelize itself and will be removed in a next v7 alpha. That should also be reflected here

[QuentinFarizon]

@mmkal sure, I wasn't the one suggesting adding it

[github-actions]

Released in v3.5.1.