Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote image classifier #2439

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Remote image classifier #2439

wants to merge 23 commits into from

Conversation

hauck-jvsh
Copy link
Member

No description provided.

@lfcnassif
Copy link
Member

Thank you very much @hauck-jvsh!

Just a couple a quick suggestions:

  • make ZipFile an inner class
  • use a non compressed ZipFile, since compressing jpeg thumbs would just waste CPU
  • replace all System.out.println calls by Logger calls

@lfcnassif lfcnassif linked an issue Feb 20, 2025 that may be closed by this pull request
@hauck-jvsh
Copy link
Member Author

I didn’t see that the compression was on, I Will change that. I will adjust the other suggestions to.

@lfcnassif
Copy link
Member

lfcnassif commented Feb 20, 2025

I think we could also encrypt thumbs before sending them since this will handle CSAM cases... Maybe we could create a new config parameter to set the server assimetric public key, so the client could send a simetric session key and we wouldn't have to deal with certificates?

@hauck-jvsh
Copy link
Member Author

hauck-jvsh commented Feb 26, 2025

I think that it is finished now, I use the same method of the DIE task to combine the scores of multiple frames of video/gifs files in to one. I just need to enable the https to encrypt all thumbs

@hauck-jvsh
Copy link
Member Author

@lfcnassif I just added the option to skip the validation of the ssl's certify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adds a new remote task to classify images
2 participants