Add overlapPolygonArea and overlapPolygonSum, deprecating overlapFeatures #389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR plits
overlapFeatures
intooverlapPolygonArea
andoverlapPolygonSum
, due to their input parameters and methods for sum and area operations diverging so much.Deprecates
overlapFeatures
and leaves it as a wrapper to the two new methods.Splits out
toMultiPolygon
andremoveOverlap
helper methods.Updates toolbox page to link directly to API doc methods.
overlapPolygonArea did get an optimization for the collection-level metric calculation where it merges the sketch collection (with overlap removed) into a single multipolygon before clipping against the features in one shot. This should be faster than clipping each child sketch (sans overlap) one at a time against the features. Testing is needed to make sure that results do not change (they do not in unit testing), but also to make sure that this does not blow up the clip function by trying to do too much at once. The default chunks size of 5000 may need to be adjusted.