-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement wait-for-object-creation
with kubectl wait
#2487
Reimplement wait-for-object-creation
with kubectl wait
#2487
Conversation
As of kubectl 1.31, there's a `kubectl wait --for=create`.
Skipping CI for Draft Pull Request. |
/test all |
wait-for-object-creation
with kubectl wait
wait-for-object-creation
with kubectl wait
/kind cleanup |
@mflendrich: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mflendrich, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As of kubectl 1.31, there's a
kubectl wait --for=create
.This should make the below excerpt of the E2E test logs less chatty and not unnecessarily highlighted as a test error.
I picked the 60s timeout value because the existing implementation does 30 retries with
sleep 1
. The extra 30s is to approximate the total currentkubectl get
latency.