Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the use of taints and tolerations in deploy, docs, examples and tests #2235

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Unify the use of taints and tolerations in deploy, docs, examples and tests #2235

merged 2 commits into from
Dec 12, 2024

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Dec 4, 2024 •
edited
Loading

Description of your changes: This PR unifies the use of taints and tolerations in our manifests, tests and docs.
All of the workloads requiring storage tolerate scylla-operator.scylladb.com/dedicated:scyllaclusters:NoSchedule taint.

/kind cleanup
/priority important-longterm

Which issue is resolved by this Pull Request:
Resolves #2049

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 4, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes: wip

/kind cleanup
/priority important-longterm
/cc

Which issue is resolved by this Pull Request:
Resolves #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@scylla-operator-bot scylla-operator-bot bot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 4, 2024
@rzetelskik rzetelskik force-pushed the unify-taints-tolerations branch 4 times, most recently from ec25692 to 39a00c5 Compare December 5, 2024 09:34
@rzetelskik
Copy link
Member Author

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel 1d945d5 link true /test e2e-gke-parallel
Full PR test history. Your PR dashboard.

manager flake
#2185 (comment)

@rzetelskik rzetelskik force-pushed the unify-taints-tolerations branch from 39a00c5 to 4e03355 Compare December 5, 2024 10:19
@rzetelskik rzetelskik changed the title [WIP] Unify the use of tains and tolerations in deploy, docs, examples and tests [WIP] Unify the use of taints and tolerations in deploy, docs, examples and tests Dec 5, 2024
@rzetelskik rzetelskik changed the title [WIP] Unify the use of taints and tolerations in deploy, docs, examples and tests Unify the use of taints and tolerations in deploy, docs, examples and tests Dec 5, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2024
@rzetelskik rzetelskik requested review from zimnx and tnozicka December 5, 2024 10:24
@rzetelskik
Copy link
Member Author

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel-clusterip 4e03355 link true /test e2e-gke-parallel-clusterip
Full PR test history. Your PR dashboard.

#2061 (comment)
manager flake...

@rzetelskik
Copy link
Member Author

/retest

tnozicka
tnozicka approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a NodeConfig / DaemonSet and NoSchedule we don't actually need them I think but it doesn't hurt.

/approve
/assign @zimnx

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
zimnx
zimnx approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rzetelskik rzetelskik force-pushed the unify-taints-tolerations branch from 4e03355 to fac7417 Compare December 11, 2024 17:38
@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@rzetelskik rzetelskik force-pushed the unify-taints-tolerations branch from fac7417 to 6c6a517 Compare December 11, 2024 17:43
@rzetelskik
Copy link
Member Author

@zimnx since ScyllaDBCluster API merged in the meantime, I also added placement to ScyllaDBCluster definition used in e2e tests, ptal

@rzetelskik rzetelskik requested a review from zimnx December 11, 2024 17:45
@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-serial 6c6a517 link true /test e2e-gke-serial
ci/prow/e2e-gke-parallel-clusterip 6c6a517 link true /test e2e-gke-parallel-clusterip
ci/prow/e2e-gke-parallel 6c6a517 link true /test e2e-gke-parallel
Full PR test history. Your PR dashboard.

logs are missing
/retest

@zimnx
Copy link
Collaborator

zimnx commented Dec 12, 2024

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit d57fab9 into scylladb:master Dec 12, 2024
13 checks passed
@rzetelskik rzetelskik deleted the unify-taints-tolerations branch December 12, 2024 09:49
@rzetelskik rzetelskik mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

@zimnx zimnx Awaiting requested review from zimnx

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify the use of tains and tolerations in deploy, docs, examples and tests
3 participants
@rzetelskik @zimnx @tnozicka