Range scans/v1 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Printing the results table with tabs proved very unreliable. The columns in some rows would often wider then expected and would push all other columns to the right making the table almost impossible to read. Instead use fmt.Printf() to print the table header and each line and define a reasonable width for each column.
Add a new mode "scan" which executes a full table scan. Later we might add options to do partial scans. The "scan" mode doesn't use a worload unlike all the other modes.
pdziepak
reviewed
Apr 25, 2018
| @@ -91,6 +91,16 @@ SELECT * from %s.%s WHERE pk = ? AND ck IN (?, ...) | |||
|
|
|||
| Counter read mode works in exactly the same as regular read mode (with the same configuration flags available) except that it reads data from the counter table `scylla_bench.test_counters`. | |||
|
|
|||
| #### Scan mode (`-mode scan`) | |||
|
|
|||
| Scan the entire table. This mode does not allow the `workload` to be configured. It is important to note that range-scans put a significant load on the cluster and also take a long time to complete. | |||
There was a problem hiding this comment.
At some point we may want to make this more configurable and not just limited to full table scans, but so far scylla-bench has been developed lazily by implementing only what was actually needed and there is no need to change that approach, especially since those changes could be done incrementally without any major rewrites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic support for range scans.