Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TotalANVI model updated #3259

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

ori-kron-wis
Copy link
Collaborator

No description provided.

@ori-kron-wis ori-kron-wis self-assigned this Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 71.61290% with 132 lines in your changes missing coverage. Please review.

Project coverage is 79.92%. Comparing base (d0abcdc) to head (26504aa).

Files with missing lines Patch % Lines
src/scvi/train/_trainingplans.py 53.00% 47 Missing ⚠️
src/scvi/external/totalanvi/_model.py 76.10% 27 Missing ⚠️
src/scvi/external/totalanvi/_module.py 82.20% 21 Missing ⚠️
src/scvi/model/_totalvi.py 70.27% 11 Missing ⚠️
src/scvi/module/_totalvae.py 78.43% 11 Missing ⚠️
src/scvi/module/base/_base_module.py 46.15% 7 Missing ⚠️
src/scvi/model/_utils.py 37.50% 5 Missing ⚠️
src/scvi/autotune/_experiment.py 0.00% 1 Missing ⚠️
src/scvi/module/_scanvae.py 75.00% 1 Missing ⚠️
src/scvi/module/_vae.py 75.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d0abcdc) and HEAD (26504aa). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (d0abcdc) HEAD (26504aa)
12 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3259      +/-   ##
==========================================
- Coverage   86.69%   79.92%   -6.77%     
==========================================
  Files         193      196       +3     
  Lines       17115    17543     +428     
==========================================
- Hits        14838    14022     -816     
- Misses       2277     3521    +1244     
Files with missing lines Coverage Δ
src/scvi/external/__init__.py 100.00% <100.00%> (ø)
src/scvi/external/totalanvi/__init__.py 100.00% <100.00%> (ø)
src/scvi/model/base/_rnamixin.py 94.55% <ø> (ø)
src/scvi/model/base/_training_mixin.py 90.77% <100.00%> (+0.98%) ⬆️
src/scvi/train/__init__.py 100.00% <ø> (ø)
src/scvi/autotune/_experiment.py 0.00% <0.00%> (ø)
src/scvi/module/_scanvae.py 85.71% <75.00%> (-0.71%) ⬇️
src/scvi/module/_vae.py 94.61% <75.00%> (-0.31%) ⬇️
src/scvi/model/_utils.py 84.81% <37.50%> (-2.69%) ⬇️
src/scvi/module/base/_base_module.py 88.23% <46.15%> (-2.08%) ⬇️
... and 5 more

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis marked this pull request as ready for review March 18, 2025 15:11
@ori-kron-wis ori-kron-wis requested a review from canergen March 18, 2025 15:11
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.3.x on-merge: backport to 1.3.x label Mar 18, 2025
@ori-kron-wis ori-kron-wis added this to the scvi-tools 1.3 milestone Mar 18, 2025
@ori-kron-wis
Copy link
Collaborator Author

Also added the scib-metrics optimization support for this model in this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autotune on-merge: backport to 1.3.x on-merge: backport to 1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants