added atom and sitemap link extractors, added attribute for xpath link #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -451,6 +451,8 @@ type : string | |||
| * ``module`` - value is a python module path. Link source is a ``scrapy.http.Response`` or subclass, depending on implementation requirements. | |||
| * ``html`` - a shortcut for ``module`` type with value ``slybot.linkextractor.HtmlLinkExtractor``. The content of the value attribute is ignored. Source is a ``scrapely.htmlpage.HtmlPage`` object or a ``scrapy.http.HtmlResponse``. | |||
| * ``rss`` - a shortcut for ``xpath`` type with value ``//item/link/text()``. The content of the value attribute is ignored. | |||
| * ``sitemap.xml`` - shortcut for ``xpath`` type with value ``//urlset/url/loc/text()`` and removed namespaces. The content of the value attribute is ignored. | |||
There was a problem hiding this comment.
I'd prefer just sitemap for the name - shorter, more consistent (none of the others use dots)
There was a problem hiding this comment.
What about nested sitemaps?
There was a problem hiding this comment.
I used sitemap.xml because the word sitemap is used in general for many types of sitemaps, but sitemap.xml is a specif format. But for me it is OK to use 'sitemap' instead (although I am not convinced to do so)
I will add support for nested sitemaps.
There was a problem hiding this comment.
Fixed both issues. PR is updated.
extractor that allows to remove namespaces.
pablohoffman
added a commit
that referenced
this pull request
Feb 1, 2014
added atom and sitemap link extractors, added attribute for xpath link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extractor that allows to remove namespaces.