test: fix broken test #1377
Merged
test: fix broken test #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold on, I just realized that ROOT is only being installed in Python 3.9. Let me see what happens if I install it in other Python versions. |
ariostas
force-pushed
the
ariostas/fix_root_test
branch
from
bba6b4c to
6e8b9bf
Compare
|
Turns out it was ROOT's fault. It probably internally changed something, but I fixed the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROOT was updated to 6.32.8 inconda-forgeand it seems to have some issue with Python 3.9. Given that the issue is with ROOT and not Uproot, and also that Python 3.9 will reach its eand-of-life later this year, I'm just disabling this test for Python 3.9.EDIT: See comments below