-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sbt to 1.9.0, migrate to new sbt syntax && Modernize a bit the CI (add ScalaSteward, dependabot and release-drafter) #220
Conversation
steps: | ||
- uses: actions/[email protected] | ||
- uses: olafurpg/setup-scala@v10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced by setup-java
as setup-scala
is using Jabba, which is not maintained anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setup-java
includes caching:
cache: sbt
Then you could remove the rm
command, too
@@ -0,0 +1,6 @@ | |||
version: 2 | |||
updates: | |||
- package-ecosystem: "github-actions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helps maintaining Github Actions workflows up-to-date
… CI (add ScalaSteward, dependabot and release-drafter)
update_release_draft: | ||
runs-on: ubuntu-20.04 | ||
steps: | ||
- uses: release-drafter/release-drafter@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically maintain a changelog in the Github releases
steps: | ||
- uses: actions/[email protected] | ||
- uses: olafurpg/setup-scala@v10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setup-java
includes caching:
cache: sbt
Then you could remove the rm
command, too
@@ -0,0 +1,16 @@ | |||
name: Scala Steward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other repos in this organisation are using the public Scala-steward, by adding the repo here: https://github.com/search?q=repo%3AVirtusLab%2Fscala-steward-repos%20sbt%2Fsbt-&type=code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, it's better to use the Github Actions. It's local to the repo, you have more control to when it's launched, you can launch it manually if needed and the PRs don't come from a fork so they're easier to update if necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
Removed
We're already using |
But even that should no longer be needed like here: https://github.com/sbt/sbt-ci-release/blob/main/.github/workflows/ci.yml |
@mzuehlke Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. I'll see about a 0.4.5 release.
Fixes #219