Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the main branch be renamed to main instead of master #298

Closed
kamleshkc2002 opened this issue Jul 6, 2020 · 7 comments · Fixed by #300
Closed

Should the main branch be renamed to main instead of master #298

kamleshkc2002 opened this issue Jul 6, 2020 · 7 comments · Fixed by #300

Comments

@kamleshkc2002
Copy link
Contributor

I'm Submitting a ...

[ ] Bug report
[X ] Tool/language/etc documentation request

Other Information

With most of the repositories moving to rename the branch master to main, i think we should also follow suit. If agreed upon, i can work on this.
@simeg
Copy link
Collaborator

simeg commented Jul 6, 2020

Sounds good to me! Not sure how much you can do without proper access to the repo but please give it a go. I don't think anyone would disagree to changing it.

@kamleshkc2002
Copy link
Contributor Author

yep, i cannot do much without having repo permissions. the least i can do is update the code references but someone has to clone the master branch into main branch.

@hugovk
Copy link
Contributor

hugovk commented Jul 7, 2020 •
edited by simeg
Loading

Then in any order:

  • Update code references to master in main branch
  • Update code references to master in health-check branch
  • Delete master branch

Finally:

  • Make sure deploys work

@kamleshkc2002
Copy link
Contributor Author

these steps definitely make sense..

once the first 2 steps are complete, i can start on the rest

@simeg
Copy link
Collaborator

simeg commented Jul 7, 2020

Ping @sb2nov 🏓

@sb2nov
Copy link
Owner

sb2nov commented Jul 7, 2020

Just updated the default branch, thank you so much for driving this :D

This was referenced Jul 8, 2020
Merged
Merged
@simeg simeg closed this as completed in #300 Jul 8, 2020
simeg pushed a commit that referenced this issue Jul 8, 2020
@kamleshkc2002 @simeg
Update references of the default branch from master to main
4294854 
After the main branch was deleted, update the code to point to `main` branch instead of `master` branch

closes #298
simeg pushed a commit that referenced this issue Jul 8, 2020
@kamleshkc2002 @simeg
update health-check branch to point to the main branch instead of `…
a194138 
…master`

Updating the health-check branch to point to the `main` branch instead of the `master` branch.

Reference issue:  #298
@simeg
Copy link
Collaborator

simeg commented Jul 8, 2020

I just verified that the deploy works. Great job everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update references of the default branch from master to main
4 participants
@hugovk @sb2nov @kamleshkc2002 @simeg