Fix v3 version #47
Open
Fix v3 version #47
+64
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samber
reviewed
Mar 23, 2025
| @@ -1,27 +1,39 @@ | |||
| module github.com/samber/slog-fiber | |||
|
|
|||
| go 1.21 | |||
| go 1.23 | |||
There was a problem hiding this comment.
is it possible to be backward compatible, down to go1.21 ?
There was a problem hiding this comment.
Hey, I don't think so.
Newest Fiber V3 beta already uses go 1.23, so go mod tidy updates the version to lowest common denominator.
Without downgrading fiber/v3 version to v3.0.0-beta.2 it's not possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied some fixes for the v3 version. I'm not yet sure whether they're 100% correct