Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/133 - Checkbox accessibility fix #134

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

tiiavalt
Copy link
Contributor

@tiiavalt tiiavalt commented Mar 4, 2021

Merge #132 before this because it has new focus styles for inputs.

Style guide's current focus styles with the color Sparkling blue are not accessible because the color ratio is only 2.02:1 so this is something that needs to be reconsidered later on.

@tiiavalt tiiavalt linked an issue Mar 4, 2021 that may be closed by this pull request
@tiiavalt tiiavalt changed the title 133 - Checkbox accessibility fix #133 - Checkbox accessibility fix Mar 5, 2021
@tiiavalt tiiavalt marked this pull request as ready for review March 5, 2021 12:17
@tiiavalt tiiavalt force-pushed the bug/133-checkbox-accessibility-fix branch from 315997d to 53c2016 Compare March 5, 2021 12:26
@tiiavalt tiiavalt changed the title #133 - Checkbox accessibility fix Bug/133 - Checkbox accessibility fix Mar 12, 2021
Copy link
Contributor

@koops9 koops9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seemed ok

@koops9 koops9 merged commit 28d410b into develop Mar 12, 2021
@koops9 koops9 deleted the bug/133-checkbox-accessibility-fix branch March 12, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility fix for checkbox
2 participants