Enlarged glphys in FiraCode Mono

[thpani]

🗹 Requirements

• I have searched the issues for my issue and found nothing related and/or helpful
• I have searched the FAQ for help
• I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:
After the v3.0.0 release, the Mono variant of FiraCode contains enlarged glyphs at codepoints U+276C to U+276F, compared to non-Mono variant and parent FiraCode 6.2.

Expected behavior:
Equal glyphs in all 3 fonts, as before v3.0.0

Example symbols:
U+276C to U+276F: ❬❭❮❯

🔧 Your Setup

• Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
  • FiraCodeNerdFontMono-Regular.ttf
• Where did you get the file from (download link, self patched, source downloaded from link...)
  • Homebrew font-fira-code-nerd-font: 3.0.0
• Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
  • kitty, macOS Terminal, also occurs in macOS TextEdit
• Are you using OS X, Linux or Windows? And which specific version or distribution?
  • macOS Ventura 13.3.1

★ Screenshots (Optional)

[Finii]

Fira Code 6.2 does not contain 276C - 276F (but just 2770 and 2771):

The glyphs you see there are inplace replacements via fontconfig.

They are patched in with these settings

{
   'Enabled': True,                                
   'Name': "Heavy Angle Brackets",         
   'Filename': "extraglyphs.sfd",                                     
   'Exact': True,       
   'SymStart': 0x276C,      
   'SymEnd': 0x2771,      
   'SrcStart': None,        
   'ScaleRules': None,                  
   'Attributes': SYM_ATTR_HEAVYBRACKETS       
}

SYM_ATTR_HEAVYBRACKETS = {
    'default': {'align': 'c', 'valign': 'c', 'stretch': 'pa', 'params': {'careful': True}}
}

probably we should add some padding? 🤔
Otoh, these glyphs are different to ordinary glyphs, they should somehow always be scaled also in Nerd Font (i.e. just setting the padding will not help there).

Thanks for reporting! Need to think a bit about the solution.

[Finii]

You see this only with v3.0.0 because previously Nerd Font did not patch in these glyphs, so you had fontfallback to the same font as with your original Fira Code. But there are a lot (?) people out there who do not have any font with the heavy brackets installed, that's the reason they are now added.

You can find out who supplies them with

$ fc-list ':charset=276c'

On my system it is mainly DejaVu:

$ fc-list :charset=276c -f '%{file}\n' | grep -v Nerd | grep '^/usr'
/usr/share/fonts/truetype/dejavu/DejaVuSans-BoldOblique.ttf
/usr/share/fonts/type1/urw-base35/D050000L.t1
/usr/share/fonts/truetype/dejavu/DejaVuSans-Bold.ttf
/usr/share/fonts/truetype/dejavu/DejaVuSansCondensed-Bold.ttf
/usr/share/fonts/truetype/freefont/FreeSerif.ttf
/usr/share/fonts/truetype/dejavu/DejaVuSansCondensed-BoldOblique.ttf
/usr/share/fonts/X11/Type1/D050000L.pfb
/usr/share/fonts/truetype/dejavu/DejaVuSans.ttf
/usr/share/fonts/truetype/dejavu/DejaVuSansMono-Bold.ttf
/usr/share/fonts/truetype/dejavu/DejaVuSansMono.ttf
/usr/share/fonts/truetype/dejavu/DejaVuSansCondensed-Oblique.ttf
/usr/share/fonts/truetype/dejavu/DejaVuSansCondensed.ttf
/usr/share/fonts/truetype/dejavu/DejaVuSans-Oblique.ttf

[Finii]

They are even scaled differently, because one is width limited and the other height limited 😒

Creating some PR.

[Finii]

Hmm, notes for PR preparation:

Height of The Three Stooges is

1495, 1495, 1682, cell height in Hack 2408.

That calculates to a padding of 15% top and bottom. Sounds reasonable.

Maybe putting in old-style ScaleGlyph group to keep the scaling identical but individually centered. The un-centeredness really bothers me... What the heck Hack?!

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.