Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional logger param #664

Merged
merged 12 commits into from
Mar 23, 2025
+257 −68
Merged

Add an optional logger param #664

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d5061b6
Add an optional logger param
tisonkun Feb 1, 2025
2851f2b
fixup MSRV
tisonkun Feb 1, 2025
a3f72c8
separate logger
tisonkun Feb 1, 2025
dd835fe
fixup msrv tests
tisonkun Feb 1, 2025
c300df0
Merge branch 'master' into logger-field
tisonkun Feb 25, 2025
cde2585
allows us to pass zero-sized logger
tisonkun Feb 27, 2025
2bb47d6
use a zero-sized GlobalLogger
tisonkun Feb 28, 2025
11af9f1
move logger expr to execute conditionally
tisonkun Mar 17, 2025
da3dd1f
add docs
tisonkun Mar 17, 2025
0bf505d
more docs
tisonkun Mar 17, 2025
66a7ab7
address comment
tisonkun Mar 18, 2025
088f9f3
address comments
tisonkun Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Merge branch 'master' into logger-field
  • Loading branch information
@tisonkun
tisonkun authored Feb 25, 2025
commit c300df094569e768c2499879ab6873ab8cf6d15c
2 changes: 1 addition & 1 deletion tests/integration.rs
View file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a good target to test our new logger param.

Previously, the global logger state is shared with all the macros tests and causes the result unstable.

Original file line number Diff line number Diff line change
@@ -97,7 +97,7 @@ fn test_line_numbers(logger: &dyn Log, state: &State) {
log::set_max_level(LevelFilter::Trace);

info!(logger: logger, ""); // ensure check_line function follows log macro
check_log_location(&state);
check_log_location(state);

#[track_caller]
fn check_log_location(state: &State) {
You are viewing a condensed version of this merge commit. You can view the full changes here.