Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all internal parse_ methods as static #2103

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

Morriar
Copy link
Contributor

@Morriar Morriar commented Nov 28, 2024

From all the methods only called from inside parse.c, some methods where marked as static some other not.

Let's standardize all of them as static unless exposed in the parse.h file.

Signed-off-by: Alexandre Terrasa <[email protected]>
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@soutaro soutaro added this to the RBS 3.7 milestone Nov 29, 2024
@soutaro soutaro added this pull request to the merge queue Nov 29, 2024
Merged via the queue into ruby:master with commit 3fc6b05 Nov 29, 2024
18 checks passed
@ParadoxV5
Copy link
Contributor

IIRC, marking internals as static removes them from the shared library’s function table. This is beneficial in binary size reductions if the header implies that they’re not meant to be exposed.

@soutaro soutaro added the Released PRs already included in the released version label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

None yet

3 participants