httr requests fail when vcr is loaded with no cassettee inserted

[aaronwolen]

library(webmockr)
library(httr)

url <- "https://httpbin.org/post"

httr_mock()
stub_request("post", url)
#> <webmockr stub> 
#>   method: post
#>   uri: https://httpbin.org/post
#>   with: 
#>     query: 
#>     body: 
#>     request_headers: 
#>   to_return: 
#>     status: 
#>     body: 
#>     response_headers: 
#>   should_timeout: FALSE
#>   should_raise: FALSE

# works
res1 <- POST(url)

# fails
library(vcr)
res2 <- POST(url)
#> Error in webmockr::HttrAdapter$new()$handle_request(req): attempt to apply non-function

# works fine once a cassette has been inserted
insert_cassette("test")
#> CrulAdapter enabled!
#> HttrAdapter enabled!
#> <vcr - Cassette> test
#>   Record method: once
#>   Serialize with: yaml
#>   Persist with: FileSystem
#>   Re-record interval (s): 
#>   Clean outdated interactions?: FALSE
#>   update_content_length_header: FALSE
#>   decode_compressed_response: 
#>   allow_playback_repeats: FALSE
#>   allow_unused_http_interactions: 
#>   exclusive: 
#>   preserve_exact_body_bytes: FALSE
res3 <- POST(url)

devtools::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value                       
#>  version  R version 3.5.1 (2018-07-02)
#>  os       macOS  10.14.6              
#>  system   x86_64, darwin15.6.0        
#>  ui       X11                         
#>  language (EN)                        
#>  collate  en_US.UTF-8                 
#>  ctype    en_US.UTF-8                 
#>  tz       America/Chicago             
#>  date     2020-01-02                  
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version  date       lib source                            
#>  assertthat    0.2.1    2019-03-21 [1] CRAN (R 3.5.1)                    
#>  backports     1.1.5    2019-10-02 [1] CRAN (R 3.5.1)                    
#>  base64enc     0.1-3    2015-07-28 [1] CRAN (R 3.5.1)                    
#>  callr         3.4.0    2019-12-09 [1] CRAN (R 3.5.1)                    
#>  cli           2.0.0    2019-12-09 [1] CRAN (R 3.5.1)                    
#>  crayon        1.3.4    2017-09-16 [1] CRAN (R 3.5.1)                    
#>  crul          0.9.0    2019-11-06 [1] CRAN (R 3.5.1)                    
#>  curl          4.3      2019-12-02 [1] CRAN (R 3.5.1)                    
#>  desc          1.2.0    2018-05-01 [1] CRAN (R 3.5.1)                    
#>  devtools      2.2.1    2019-09-24 [1] CRAN (R 3.5.1)                    
#>  digest        0.6.23   2019-11-23 [1] CRAN (R 3.5.1)                    
#>  ellipsis      0.3.0    2019-09-20 [1] CRAN (R 3.5.1)                    
#>  evaluate      0.14     2019-05-28 [1] CRAN (R 3.5.1)                    
#>  fansi         0.4.0    2018-10-05 [1] CRAN (R 3.5.1)                    
#>  fauxpas       0.2.0    2018-03-01 [1] CRAN (R 3.5.1)                    
#>  fs            1.3.1    2019-05-06 [1] CRAN (R 3.5.1)                    
#>  glue          1.3.1    2019-03-12 [1] CRAN (R 3.5.1)                    
#>  highr         0.8      2019-03-20 [1] CRAN (R 3.5.1)                    
#>  htmltools     0.4.0    2019-10-04 [1] CRAN (R 3.5.1)                    
#>  httpcode      0.2.0    2016-11-14 [1] CRAN (R 3.5.1)                    
#>  httr        * 1.4.1    2019-08-05 [1] CRAN (R 3.5.1)                    
#>  jsonlite      1.6      2018-12-07 [1] CRAN (R 3.5.1)                    
#>  knitr         1.26     2019-11-12 [1] CRAN (R 3.5.1)                    
#>  lazyeval      0.2.2    2019-03-15 [1] CRAN (R 3.5.1)                    
#>  magrittr      1.5      2014-11-22 [1] CRAN (R 3.5.1)                    
#>  memoise       1.1.0    2017-04-21 [1] CRAN (R 3.5.1)                    
#>  pkgbuild      1.0.6    2019-10-09 [1] CRAN (R 3.5.1)                    
#>  pkgload       1.0.2    2018-10-29 [1] CRAN (R 3.5.1)                    
#>  prettyunits   1.0.2    2015-07-13 [1] CRAN (R 3.5.1)                    
#>  processx      3.4.1    2019-07-18 [1] CRAN (R 3.5.1)                    
#>  ps            1.3.0    2018-12-21 [1] CRAN (R 3.5.1)                    
#>  R6            2.4.1    2019-11-12 [1] CRAN (R 3.5.1)                    
#>  Rcpp          1.0.3    2019-11-08 [1] CRAN (R 3.5.1)                    
#>  remotes       2.1.0    2019-06-24 [1] CRAN (R 3.5.1)                    
#>  rlang         0.4.2    2019-11-23 [1] CRAN (R 3.5.1)                    
#>  rmarkdown     2.0      2019-12-12 [1] CRAN (R 3.5.1)                    
#>  rprojroot     1.3-2    2018-01-03 [1] CRAN (R 3.5.1)                    
#>  sessioninfo   1.1.1    2018-11-05 [1] CRAN (R 3.5.1)                    
#>  stringi       1.4.3    2019-03-12 [1] CRAN (R 3.5.1)                    
#>  stringr       1.4.0    2019-02-10 [1] CRAN (R 3.5.1)                    
#>  testthat      2.3.1    2019-12-01 [1] CRAN (R 3.5.1)                    
#>  triebeard     0.3.0    2016-08-04 [1] CRAN (R 3.5.1)                    
#>  urltools      1.7.3    2019-04-14 [1] CRAN (R 3.5.1)                    
#>  usethis       1.5.1    2019-07-04 [1] CRAN (R 3.5.1)                    
#>  vcr         * 0.4.1.93 2020-01-02 [1] Github (ropensci/vcr@124b386)     
#>  webmockr    * 0.5.1.94 2020-01-02 [1] Github (ropensci/webmockr@204e5e3)
#>  withr         2.1.2    2018-03-15 [1] CRAN (R 3.5.1)                    
#>  xfun          0.11     2019-11-12 [1] CRAN (R 3.5.1)                    
#>  yaml          2.2.0    2018-07-25 [1] CRAN (R 3.5.1)                    
#> 
#> [1] /Users/aaronwolen/R
#> [2] /Library/Frameworks/R.framework/Versions/3.5.1-MRO/Resources/library

^{Created on 2020-01-02 by the reprex package (v0.3.0)}

I'm working on a PR with a fix.

[sckott]

thanks!

[aaronwolen]

Let me verify something: if a request is both stubbed and recorded to a cassette, then we should preferentially return the stubbed response, right?

[aaronwolen]

Never mind, I got a little lost in the request_is_in_cache(request_signature) block; checking for vcr in two different places threw me off.

[sckott]

let me know if you still have questions