-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mregions2: Access Data from Marineregions.org: The Marine Regions Gazetteer and the Marine Regions Data Products #590
Comments
Thanks for submitting to rOpenSci, our editors and @ropensci-review-bot will reply soon. Type |
🚀 Editor check started 👋 |
Checks for mregions2 (v1.0.0)git hash: 9ed0de6d
Package License: MIT + file LICENSE 1. Package DependenciesDetails of Package Dependency Usage (click to open)
The table below tallies all function calls to all packages ('ncalls'), both internal (r-base + recommended, along with the package itself), and external (imported and suggested packages). 'NA' values indicate packages to which no identified calls to R functions could be found. Note that these results are generated by an automated code-tagging system which may not be entirely accurate.
Click below for tallies of functions used in each package. Locations of each call within this package may be generated locally by running 's <- pkgstats::pkgstats(<path/to/repo>)', and examining the 'external_calls' table. magrittr%>% (200) basec (28), url (11), source (9), tolower (9), for (8), list (8), names (8), subset (8), all (7), as.character (7), unique (7), file.path (5), options (5), paste0 (5), data.frame (4), format (4), length (4), seq_along (4), gsub (3), if (3), version (3), class (2), dim (2), is.null (2), lapply (2), nrow (2), tempdir (2), as.integer (1), by (1), difftime (1), file.info (1), getOption (1), ifelse (1), is.na (1), readLines (1), rm (1), sort (1), substitute (1), Sys.getenv (1), unlist (1), with (1) mregions2mrp_view (14), is_error (11), marineregions.org (9), base_map (3), gaz_records_by_name_at (3), gaz_rest_sources (3), get_records_by_lat_long_at (3), get_records_by_type_at (3), get_source_at (3), gaz_rest_geometries (2), gaz_rest_record_by_mrgid (2), gaz_rest_records_by_lat_long (2), gaz_rest_records_by_names (2), gaz_rest_source_by_sourceid (2), gaz_rest_types (2), gaz_search.sfg (2), add_labels (1), assert_deps (1), assert_internet (1), assert_mrgid_exists (1), assert_only_one_filter (1), assert_placetype (1), assert_service (1), assert_typeid (1), c_rdf (1), cache_max_time (1), check_if_missing (1), check_server_warning (1), gaz_add_geometry (1), gaz_geometry (1), gaz_geometry.mr_df (1), gaz_geometry.numeric (1), gaz_relations (1), gaz_relations.mr_df (1), gaz_relations.numeric (1), gaz_rest_geometry (1), gaz_rest_names_by_mrgid (1), gaz_rest_records_by_name (1), gaz_rest_records_by_source (1), gaz_rest_records_by_type (1), gaz_rest_relations_by_mrgid (1), gaz_rest_wmses (1), gaz_search (1), gaz_search_by_source (1), gaz_search_by_source.character (1), gaz_search_by_source.numeric (1), gaz_search_by_type (1), gaz_search_by_type.character (1), gaz_search_by_type.numeric (1), gaz_search.character (1), gaz_search.numeric (1), gaz_search.sf (1), gaz_search.sfc (1), geom_perform (1), is_internet_down (1), is_test (1), mr_memoise (1), mrp_get (1), mrp_get_sanity_check (1), mrp_view_cds (1), mrp_view_eca_reg13_nox (1), mrp_view_eca_reg14_sox_pm (1), mrp_view_ecoregions (1), mrp_view_ecs (1), mrp_view_ecs_boundaries (1), mrp_view_eez (1), mrp_view_eez_12nm (1), mrp_view_eez_24nm (1), mrp_view_eez_archipelagic_waters (1), mrp_view_eez_boundaries (1), mrp_view_eez_iho (1) httr2req_headers (12), req_error (11), resp_check_status (8), resp_status (5), req_url_query (4), request (3), url_parse (3), url_build (2), resp_body_string (1), resp_is_error (1), resp_status_desc (1) checkmateassert_character (15), assert_integerish (15), assert_int (4), assert_logical (4), assert_numeric (3), assert_data_frame (2), assert_double (2) statsoffset (18), filter (5), df (1) methodscoerce (18), is (1) glueglue (18) sfst_read (3), st_as_sfc (2), st_bbox (2), st_crs (2), st_point (2), st_sfc (2), st_coordinates (1) leaflettileOptions (3), leafletCRS (2), leafletOptions (2), addTiles (1), leaflet (1), WMSTileOptions (1) clicli_abort (7) memoisememoise (5) dplyrright_join (2), bind_rows (1) utilsunzip (3) digestdigest (2) ISOcodesISO_639_2$Alpha_2 (1), ISO_639_2$Name (1) rdflibrdf_serialize (1) xml2xml_attr (1) NOTE: Some imported packages appear to have no associated function calls; please ensure with author that these 'Imports' are listed appropriately. 2. Statistical PropertiesThis package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing. Details of statistical properties (click to open)
The package has:
Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages
All parameters are explained as tooltips in the locally-rendered HTML version of this report generated by the The final measure (
2a. Network visualisationClick to see the interactive network visualisation of calls between objects in package 3.
|
id | name | conclusion | sha | run_number | date |
---|---|---|---|---|---|
4809625294 | pages build and deployment | success | c80782 | 33 | 2023-04-26 |
4807668829 | pkgcheck | success | 9ed0de | 82 | 2023-04-26 |
4809552258 | pkgdown | success | 9ed0de | 49 | 2023-04-26 |
4807666863 | R-CMD-check | success | 9ed0de | 31 | 2023-04-26 |
4807668826 | R-CMD-check-schedule | success | 9ed0de | 122 | 2023-04-26 |
4807666847 | test-coverage | success | 9ed0de | 30 | 2023-04-26 |
3b. goodpractice
results
R CMD check
with rcmdcheck
R CMD check generated the following note:
- checking data for non-ASCII characters ... NOTE
Note: found 1 marked UTF-8 string
R CMD check generated the following check_fail:
- rcmdcheck_non_ascii_characters_in_data
Test coverage with covr
Package coverage: 91.54
Cyclocomplexity with cyclocomp
The following functions have cyclocomplexity >= 15:
function | cyclocomplexity |
---|---|
gaz_rest_records_by_name | 19 |
gaz_add_geometry | 15 |
Static code analyses with lintr
lintr found the following 403 potential issues:
message | number of times |
---|---|
Avoid library() and require() calls in packages | 11 |
Lines should not be more than 80 characters. | 392 |
Package Versions
package | version |
---|---|
pkgstats | 0.1.3.4 |
pkgcheck | 0.1.1.23 |
Editor-in-Chief Instructions:
This package is in top shape and may be passed on to a handling editor
Thanks @salvafern for this submission and for pointing to ropensci-archive/mregions#62. How can we leave a record that the maintainer of mregions is OK with the decision of submitting mregions2? Maybe you can point me to an GH-issue comment? |
Hi @maurolepore, thanks for checking out! 🚀 I am actually the current maintainer of mregions (ropensci-archive/mregions@e5fb45b). Before me were @LennertSchepers and @sckott (ropensci-archive/mregions@dd7b6e4). Since we had this public conversation on ropensci-archive/mregions#62, and also got the idea of a new package from @maelle (see ropensci-archive/mregions#62 (comment)), I think we are all on the same page about submitting mregions2. But if there is any objection from Lennert or Scott I'm happy to discuss of course 😃 |
No objection from me |
No objection from me, @salvafern is in our team so we discussed the whole process in detail. |
Worth noting if you need written approval: we are also the Marine Regions data system developers/maintainers/owners (see e.g. https://marineregions.org/editors.php) |
Thanks @salvafern and everyone else for your support. |
@ropensci-review-bot assign @jooolia as editor |
Assigned! @jooolia is now the editor |
Editor checks:
Editor commentsDear @salvafern and @whaleshark99, Thanks for your submission. Overall the package is in great shape. The only thing that I would note would that it would be even better with more information on how to contribute to the package. Feel free to let me know if there is a reason that additional info should not be added. I will start looking for reviewers. Cheers, Julia |
@ropensci-review-bot seeking reviewers |
Please add this badge to the README of your package repository: [](https://github.com/ropensci/software-review/issues/590) Furthermore, if your package does not have a NEWS.md file yet, please create one to capture the changes made during the review process. See https://devguide.ropensci.org/releasing.html#news |
Hello, I am still actively looking for reviewers. Thanks, Julia |
@jooolia I accept your invitation to review it. This is my first attempt to review a package. |
@jooolia I found the guidelines https://devguide.ropensci.org/reviewerguide.html |
@ropensci-review-bot assign @Kattuvan as reviewer |
@Kattuvan added to the reviewers list. Review due date is 2023-06-20. Thanks @Kattuvan for accepting to review! Please refer to our reviewer guide. rOpenSci’s community is our best asset. We aim for reviews to be open, non-adversarial, and focused on improving software quality. Be respectful and kind! See our reviewers guide and code of conduct for more. |
Thanks @Kattuvan for agreeing to review! Glad that you found the guide. :) |
@ropensci-review-bot assign @sheilasaia as reviewer |
@sheilasaia added to the reviewers list. Review due date is 2023-06-21. Thanks @sheilasaia for accepting to review! Please refer to our reviewer guide. rOpenSci’s community is our best asset. We aim for reviews to be open, non-adversarial, and focused on improving software quality. Be respectful and kind! See our reviewers guide and code of conduct for more. |
Hello @salvafern, sorry for the delay in my handling. I missed these updates. :( |
Hi @Kattuvan, |
Hi,Please move the submission to the next level.
Regards,Murali
On Thursday, February 22, 2024 at 08:44:27 a.m. EST, salvafern ***@***.***> wrote:
Hi @jooolia, did you receive any message from @Kattuvan ? Any chance to move this submission forward?
Best, Salva
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi @jooolia , please let me know if there is anything else I can do on my side to move this submission forward. |
Dear Salva,
Sorry for the delay. I will get back to you at the latest by March 10th.
Thank you for your patience.
Cheers, Julia
Le lun. 4 mars 2024, 16:02, salvafern ***@***.***> a écrit :
… Hi @jooolia <https://github.com/jooolia> , please let me know if there is
anything else I can do on my side to move this submission forward.
Best, Salva
—
Reply to this email directly, view it on GitHub
<#590 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOPZSXTJENIDT2YUMMWATDYWSEIBAVCNFSM6AAAAAAXMQPDZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZWG44DGOBRGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Dear @salvafern, Thanks! |
Hi @jooolia, apologies for the delay. The logs are fresh now: https://github.com/lifewatch/mregions2/actions/runs/8615096758/job/23609894330 I think the same issue continues: See ropensci/mregions2#21 and ropensci/rdflib#47 Any ideas are highly appreciated! |
Thanks @salvafern for the reruns. I will have a look and get back to you (and it seems that rdflib has commented out the ubuntu tests for now). thanks, Julia |
Hi @salvafern , I have forked mregions2 and will look into the github actions tomorrow. thanks for your patience. |
That's great, thank you! |
Hi @salvafern, I have gotten R-CMD-check to run without errors, although it is a bit of a workaround at the moment. I will look into the yaml files tonight and update you then (or if all goes well submit a pull request) with what has worked and what we could imagine doing. |
Hi @salvafern I have opened a PR in the repo to your dev branch. Let me know what you think. I had to remove pkgcheck, but all three others I was able to get to work and pass. |
Hi @jooolia , I have merge your PR to the main branch. Seems to work fine now. Thanks a lot! Let me know what are the next steps. |
@ropensci-review-bot approve mregions2 |
Approved! Thanks @salvafern for submitting and @Kattuvan, @sheilasaia for your reviews! 😁 To-dos:
Should you want to acknowledge your reviewers in your package DESCRIPTION, you can do so by making them Welcome aboard! We'd love to host a post about your package - either a short introduction to it with an example for a technical audience or a longer post with some narrative about its development or something you learned, and an example of its use for a broader readership. If you are interested, consult the blog guide, and tag @ropensci/blog-editors in your reply. They will get in touch about timing and can answer any questions. We maintain an online book with our best practice and tips, this chapter starts the 3d section that's about guidance for after onboarding (with advice on releases, package marketing, GitHub grooming); the guide also feature CRAN gotchas. Please tell us what could be improved. Last but not least, you can volunteer as a reviewer via filling a short form. |
@ropensci-review-bot invite me to ropensci/mregions2 |
Invitation sent! |
@ropensci-review-bot finalize transfer of mregions2 |
Transfer completed. |
Date accepted: 2024-06-09
Submitting Author Name: Salvador Fernández Bejarano
Due date for @Kattuvan: 2023-06-20Submitting Author Github Handle: @salvafern
Other Package Authors Github handles: (comma separated, delete if none) @lottepohl
Repository: https://github.com/lifewatch/mregions2
Version submitted:
Submission type: Standard
Editor: @jooolia
Reviewers: @Kattuvan, @sheilasaia
Due date for @sheilasaia: 2023-06-21
Archive: TBD
Version accepted: TBD
Language: en
Scope
This package reads the Marine Regions Gazetteer and the Marine Regions Data Products via a REST API and OGC web services respectively. The data is mostly geospatial as it contains locations of marine places in the world.
The main purpose of Marine Regions is to serve as the geographical backbone of biodiversity databases such as WoRMS or EurOBIS, hence the main user will be scientists that want to geo-reference their research. But it can also be useful for industry, policy and law makers.
There is already a package to read Marine Regions. The need for this second package is explained in one of the package's articles: Why mregions2? . It was also discussed beforehand that a new package was the best approach: ropensci-archive/mregions#62 (Mostly to not break compatibility)
In general I think this does not apply. The only data being collected from users is the user-agent in all HTTP requests. This gets the environment variable
HTTPUserAgent
viagetOption()
in mr_user_agentOn the other hand, Marine Regions has sensitive data products such as the maritime boundaries. It is stated clearly on our disclaimer that the data has no legal value whatsoever.
pkgcheck
items which your package is unable to pass.Technical checks
Confirm each of the following by checking the box.
This package:
Publication options
Do you intend for this package to go on CRAN?
Do you intend for this package to go on Bioconductor?
Do you wish to submit an Applications Article about your package to Methods in Ecology and Evolution? If so:
MEE Options
Code of conduct
The text was updated successfully, but these errors were encountered: