Define AP field for Infinite on purecap and legacy exts #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tariqkurd-repo : I resolved all your comments because we talked through them and I made changes as discussed. Could you take another look? Thanks! |
tariqkurd-repo
approved these changes
Apr 12, 2024
arichardson
reviewed
Apr 12, 2024
Co-authored-by: Alexander Richardson <[email protected]> Signed-off-by: Andres Amaya Garcia <[email protected]>
arichardson
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MXLEN=32 encoding for the AP field was recently changed. However, the following remained unclear:
For (1), this change ensures that the AP encodings for Mode=Legacy are "reserved" in valid capabilities (ie. we cannot have a valid tag with an encoding that has Mode=Legacy).
For (2), the tables and text are updated such that the AP encoding for the Infinite Capability is: