Bug #1786509: Plank hides unexpectedly with autohide enabled in left or top positions #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed the `update_hovered_with_coords` call in `handle_leave_notify_event` to pass the actual x and y coordinates instead of -1 as args to ensure `Hovered` isn't set to false when `handle_leave_notify_event` is mistakenly called and the pointer is still within the dock 'window' area. bug description: https://bugs.launchpad.net/plank/+bug/1786509 `handle_leave_notify_event` gets called sporadically (due to `window.leave_notify_event` bring triggered) when the dock is set to left or top, the pointer is on the edge of the screen and when auto-hide setting is enabled. this results in the dock hiding itself when it shouldn't. I reproduced this on archlinux with xfce.
lilly-lizard
changed the title
|
This seems to be fixed in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
https://bugs.launchpad.net/plank/+bug/1786509
When plank is on the top or left position, autohide doesn't work as expected. Moving the mouse pointer along the edge of the screen causes plank to randomly hide and unhide itself (as shown in the video attached to the bug report, although unlike in the original bug report I can see this happen next to icons as well).
I've reproduced this on archlinux with xfce.
Cause
window.leave_notify_eventgets triggered sporadically (which callshandle_leave_notify_event) when the pointer is on the top or left edge of the screen.Changes
Changed the
update_hovered_with_coordscall inhandle_leave_notify_eventto pass the actual x and y coordinates instead of -1 as args. This ensuresHoveredisn't set to false whenhandle_leave_notify_eventis mistakenly called while the mouse pointer is actually within the dock 'window' area. Unhiding still works as normal otherwise.