Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formatting diff on typecheck #2717

Merged
merged 34 commits into from
Apr 30, 2023
Merged

Add formatting diff on typecheck #2717

merged 34 commits into from
Apr 30, 2023

Conversation

davesnx
Copy link
Member

@davesnx davesnx commented Apr 25, 2023 •
edited
Loading

  • Rename typedtree to outcometree (to be correct cc @anmonteiro)
  • Added the printed output for the typeChecked tests
  • Removed unused scripts/failing commands from Make

davesnx added 30 commits March 25, 2023 00:14
@davesnx
Remove old tests
690c244
@davesnx
Remove miscTests
2687d48
@davesnx
Remove azure
3c022bf
@davesnx
Remove CircleCI
25672c8
@davesnx
Merge branch 'master' of github.com:/reasonml/reason
33d181c 
* 'master' of github.com:/reasonml/reason:
  Fix version on refmt (#2701)
  Drop the result dependency (#2703)
  Remove old CI and test.sh (#2705)
@davesnx
Merge branch 'master' of github.com:/reasonml/reason
da042bc 
* 'master' of github.com:/reasonml/reason:
  chore: port to ppxlib (#2711)
  fix: binary parser (#2713)
  Improve functor printing. (#2683)
  chore: remove old BS_NO_COMPILER_PATCH flag (#2710)
  Improve printing of modules types with one line inside (#2709)
  generate opam files with dune (#2704)
@davesnx
Add output/basics to basics.t
4f6c4d0
@davesnx
Add formatting to basics_no_semi, add cases from basics
a4a3976
@davesnx
Add formatting to typeParameters
f320cf4
@davesnx
Add formatting to sequences
eec1e4c
@davesnx
Add formatting to patternMatching, add more cases
43f098d
@davesnx
Add formatting to oo
5d1989c
@davesnx
Add formatting to mutation
aefb4a9
@davesnx
Add formatting to letop
11217de
@davesnx
Add formatting to lazy
9445463
@davesnx
Add formatting to knownReIssues
749cdb9
@davesnx
Add formatting to bigarraySyntax
bcab8ce
@davesnx
Add formatting to reasonComments
89db33a
@davesnx
Add formatting to attributes
9baede8
@davesnx
Add formatting to type-pipeFirst
8e3b413
@davesnx
Add formatting to imperative
fd71794
@davesnx
Run tests on macosx for 4.10 and 4.12
d3c7a83
@davesnx
Polish esy/makefile interface
a2f7342
@davesnx
Add formatting to type-jsx
9f73900
@davesnx
Add formatting to reasonComments for 4.10
f84fa72
@davesnx
Add formatting to objects for 4.06
d852b71
@davesnx
Rename typedtree to outcometree
32314af
@davesnx
Rename typedtree to outcome
2849ea7
@davesnx
Add formatting to attributes @ 4.12
e864d14
@davesnx
Add formatting to attributes @ 4.06
3e62331
@davesnx davesnx force-pushed the Add-formatting-diff-on-typecheck branch from 7303a30 to e8da79c Compare April 27, 2023 20:18
@davesnx davesnx marked this pull request as ready for review April 28, 2023 08:45
@davesnx davesnx requested a review from anmonteiro April 28, 2023 08:45
@anmonteiro anmonteiro merged commit 95485d5 into master Apr 30, 2023
@anmonteiro anmonteiro deleted the Add-formatting-diff-on-typecheck branch April 30, 2023 19:41
@anmonteiro
Copy link
Member

Thanks!

SanderSpies added a commit to SanderSpies/reason that referenced this pull request May 4, 2023
@SanderSpies
Merge branch 'master' into sanderspies/pprint
0434304 
* master:
  Add formatting diff on typecheck (reasonml#2717)
  feat: Support OCaml 5.1 (reasonml#2714)
  chore: port to ppxlib (reasonml#2711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmonteiro anmonteiro Awaiting requested review from anmonteiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davesnx @anmonteiro