Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2219 Add test to verify upload progress notifications during client reset #7958

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

michael-wb
Copy link
Contributor

@michael-wb michael-wb commented Aug 6, 2024

What, How & Why?

Added test to verify the streaming and non-streaming upload progress notifications when registered prior to a client reset. The upload notifications should not be reported until after the client reset diff is performed and should include reporting on the local changes that need to be uploaded after the client reset.

This test verifies the progress notifications for both PBS and FLX sync sessions for each of the following cases:

  • No local or remote changes
  • Local changes only
  • Remote changes only
  • Both local and remote changes

Fixes #7932

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed
  • [ ] bindgen/spec.yml, if public C++ API changed

Sorry, something went wrong.

Unverified

No user is associated with the committer email.
@michael-wb michael-wb self-assigned this Aug 6, 2024
@cla-bot cla-bot bot added the cla: yes label Aug 6, 2024
Michael Wilkerson-Barker added 2 commits August 6, 2024 19:36

Unverified

No user is associated with the committer email.

Unverified

No user is associated with the committer email.
Copy link

Pull Request Test Coverage Report for Build michael.wilkersonbarker_1319

Details

  • 132 of 132 (100.0%) changed or added relevant lines in 1 file are covered.
  • 34 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.04%) to 91.138%

Files with Coverage Reduction New Missed Lines %
src/realm/sync/noinst/server/server.cpp 1 74.69%
test/test_lang_bind_helper.cpp 2 93.2%
src/realm/sync/noinst/server/server_history.cpp 5 62.66%
src/realm/util/file.cpp 5 84.45%
src/realm/sync/noinst/client_impl_base.cpp 6 82.52%
src/realm/bplustree.cpp 7 72.39%
src/realm/index_string.cpp 8 84.63%
Totals Coverage Status
Change from base Build 2546: 0.04%
Covered Lines: 217315
Relevant Lines: 238447

💛 - Coveralls

Michael Wilkerson-Barker added 3 commits August 7, 2024 14:15

Unverified

No user is associated with the committer email.
… bootstrap
…ad-progress-test

Unverified

No user is associated with the committer email.
@michael-wb michael-wb marked this pull request as draft August 12, 2024 19:54

Unverified

No user is associated with the committer email.
…ad-progress-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test to verify upload progress notifications during client reset
1 participant