-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kagi-search extension #18191
base: main
Are you sure you want to change the base?
Update kagi-search extension #18191
Conversation
- ray lint --fixed - clean up lint warns - manifest updates for publishing - update node to fix build type errors - forked edits - Initial commit
Thank you for your first contribution! 🎉 🔔 @fearoffish you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
extensions/kagi-search/package.json
Outdated
@@ -5,12 +5,15 @@ | |||
"description": "Searches the Closed Beta of Kagi Search, using the autosuggestions url.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rename this, because it's not a Closed Beta anymore?
it's technically still in closed beta, i think: https://help.kagi.com/kagi/api/search.html
: j
…On Mar 27, 2025 at 10:35 AM -0700, Jamie van Dyke ***@***.***>, wrote:
@fearoffish commented on this pull request.
In extensions/kagi-search/package.json:
> @@ -5,12 +5,15 @@
"description": "Searches the Closed Beta of Kagi Search, using the autosuggestions url.",
Maybe rename this, because it's not a Closed Beta anymore?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR integrates FastGPT query support into the kagi-search extension, updates package configuration, and refines search result handling.
- extensions/kagi-search/package.json: Added a new apiKey preference and refreshed dependencies.
- extensions/kagi-search/src/index.tsx: Introduced conditional FastGPT view rendering and diversified action handling.
- extensions/kagi-search/CHANGELOG.md: New entry uses an actual date instead of the required "{PR_MERGE_DATE}" template.
- extensions/kagi-search/src/fastgpt-view.tsx: FastGPT fetch logic works as intended but lacks cleanup for its AbortController.
- extensions/kagi-search/src/utils/kagiApi.ts: Noted inconsistent error handling between searchWithKagiAPI and searchWithFastGPT.
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
10 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
fixed space in browser line Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
updated- changes suggested by Greptile have been made. It won't let me run publish again due to "unrelated histories." But the latest (4eb95e7) should be good |
Description
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder