Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable pathname spacing #2349

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

TankedThomas
Copy link

Fixes #1043 (additional fixes, this time for external/pico_sdk_import.cmake).

Some pathname spacing (and special characters) still causes issues.
Related to this pull request from raspberrypi/debugprobe.

I'm not 100% sure about this pull request because I couldn't replicate the issue with pico-sdk, but since I had this issue with downstream and these fixes worked (and for consistency), I figured it was worth pushing the changes upstream anyway.

Signed-off-by: TankedThomas <[email protected]>
@lurch
Copy link
Contributor

lurch commented Mar 11, 2025

I'm not 100% sure about this pull request because I couldn't replicate the issue with pico-sdk

That's probably because this cmake file is in external/ and there's nothing in pico-sdk itself which actually uses it! It only exists so that it can be copied into external projects (like debugprobe) that wish to make use of pico-sdk 🙂

@TankedThomas
Copy link
Author

I'm not 100% sure about this pull request because I couldn't replicate the issue with pico-sdk

That's probably because this cmake file is in external/ and there's nothing in pico-sdk itself which actually uses it! It only exists so that it can be copied into external projects (like debugprobe) that wish to make use of pico-sdk 🙂

Ah, right. So it's worth keeping the changes then, since it'll be pulled downstream by other projects.

@kilograham kilograham self-assigned this Mar 18, 2025
@kilograham kilograham added this to the 2.1.2 milestone Mar 18, 2025
@kilograham
Copy link
Contributor

Keeping this around, but will copy the upstream version when it is updated

@lurch
Copy link
Contributor

lurch commented Mar 18, 2025

Keeping this around, but will copy the upstream version when it is updated

Huh, what's "upstream" of pico-sdk?

@lurch lurch added the build label Mar 18, 2025
@kilograham
Copy link
Contributor

upstream FreeRTOS FreeRTOS/FreeRTOS-Kernel#1255

@lurch
Copy link
Contributor

lurch commented Mar 19, 2025

Ahhh, I hadn't seen that issue. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants