Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fourth fuzzer for injecting comments #2822

Open
wants to merge 74 commits into
base: fuzz-dollar
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Mar 10, 2025

Part of #2191 -- continuing #2821 (which is included here & against which this is based, for now). Also progress on #2737.

Closes #2824. Closes #2825. Closes #2826. Closes #2827.

Wow, this one really spiralled out of control & became quite a quixotic endeavor in the end.

A lot of it is really edge-casey, but better to have the fix than not. A surprising number of legit issues / bugs (i.e. not false positive/negative, but {lintr} errors based on faulty assumptions).

Probably, some pieces of this belong in dedicated PRs separate from this one.

Filing for now to get things started.

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (c3a99ce) to head (a42bda5).

Additional details and impacted files
@@             Coverage Diff              @@
##           fuzz-dollar    #2822   +/-   ##
============================================
  Coverage        99.64%   99.64%           
============================================
  Files              126      126           
  Lines             6978     7041   +63     
============================================
+ Hits              6953     7016   +63     
  Misses              25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant