New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`object_name_linter()` doesn't lint `assign()` and `setGeneric()` calls #1665

Closed

IndrajeetPatil opened this issue Oct 11, 2022 · 0 comments · Fixed by #2766

Labels

Collaborator

IndrajeetPatil commented Oct 11, 2022

Discovered while working on #1664:

library(lintr)

lint(
  text = 'assign("myVar", 2L)',
  linters = object_name_linter(styles = c("dotted.case", "lowercase"))
)

lint(
  text = 'setGeneric("MY_VAR", function(object) attributes(object))',
  linters = object_name_linter(styles = c("camelCase", "CamelCase"))
)

^{Created on 2022-10-11 with reprex v2.0.2}

IndrajeetPatil added the false-negative label

IndrajeetPatil mentioned this issue

Add examples to documentation: Part-6 (o-p) #1664

Merged

MichaelChirico mentioned this issue

Catch bad naming style (and length) in assign() + setGeneric() usages #2766

Merged

AshesITR closed this as completed in #2766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment