Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add remove command #232

Closed
cromefire opened this issue May 19, 2023 · 2 comments · Fixed by #257
Closed

[feature] Add remove command #232

cromefire opened this issue May 19, 2023 · 2 comments · Fixed by #257

Comments

@cromefire
Copy link

It would be really nice if there would be a remove command similar to the remove command in hdr10plus_tool that removes dolby vision metadata from the stream. I have some files with seemingly damaged dolby vision metadata, so it would be nice to be able to remove it without needing to transcode them.

@quietvoid
Copy link
Owner

quietvoid commented May 19, 2023

This is already supported through demux.
But maybe it could be worth having a remove subcommand as well.

As the NALUs are known, FFmpeg can be used to filter out type 62/63 as well.

@cromefire
Copy link
Author

cromefire commented May 19, 2023

You are completely right didn't notice the little notice:

Also can be used to remove the RPUs from an HEVC file.

Maybe an example with a remove heading in the README or a remove "shortcut" could be nice though. Because right now from the README I'm not quite sure whether just a normal demux already removes if or whether I need any specific flag or so, because from the description it only removes the EL, but I have files with profile 8.1, so as far as I understand there is no EL. Might just be a little deficiency in documentation.

Edit: It seems the demux command works, so basically a remove command would only need a mapping of --output to --bl-out and set --el-out to /dev/null

quietvoid added a commit that referenced this issue Oct 7, 2023
quietvoid added a commit that referenced this issue Oct 7, 2023
quietvoid added a commit that referenced this issue Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants