Implement FileWatcher #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
commented
Nov 6, 2020
src/directory/file_watcher.rs
Outdated
|
|
||
| while state.load(Ordering::Relaxed) == 1 { | ||
| if let Ok(checksum) = FileWatcher::compute_checksum(&path) { | ||
| if current_checksum.is_none() || current_checksum.unwrap() != checksum { |
There was a problem hiding this comment.
i prefer if let Some(current_checksum)= current_checksum_opt to make the it visible that this code cannot panic.
fulmicoton
commented
Nov 6, 2020
src/directory/file_watcher.rs
Outdated
| thread::sleep(if cfg!(test) { | ||
| Duration::from_millis(1) | ||
| } else { | ||
| DEFAULT_POLLING_INTERVAL |
There was a problem hiding this comment.
should we change the default value in test instead?
There was a problem hiding this comment.
the value of DEFAULT_POLLING_INTERVAL i mean
guilload
force-pushed
the
guilload--implement-poll-watcher
branch
from
c480bd6 to
5e54eda
Compare
guilload
force-pushed
the
guilload--implement-poll-watcher
branch
from
5e54eda to
2875deb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.